-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create CustomPropertiesStream class #268
base: main
Are you sure you want to change the base?
Conversation
feat: create CustomPropertiesStream class
Seeing a 404 in the tests: Perhaps we should think of a way of skipping/deselecting this stream for non-org namespaces? |
Is there already an example with that? And how to tell if a namespace is org / non-org? |
@MindaugasN I think moving it here tap-github/tap_github/streams.py Lines 118 to 121 in f41b66d
would be enough |
feat: create CustomPropertiesStream class
I moved, but first of all, I am not sure, if I did that correctly. |
Can you say more about this? What do you mean it's not working anymore?
Not really. The stream class can stay in
I think you're missing a newline at the end of |
feat: create CustomPropertiesStream class
feat: create CustomPropertiesStream class
Got it, that solved all my problems :) And with the test - I ran Black locally and formatted my code |
feat: create CustomPropertiesStream class
I think we're back at #268 (comment) 😅 |
create CustomPropertiesStream class that fetches data from https://docs.github.com/en/rest/repos/custom-properties?apiVersion=2022-11-28